Revert the revert hanging block, and fix the issues #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasDorier
force-pushed
the
feature/hanging-block
branch
from
6030f6f
to
bddc491
Compare
NicolasDorier
changed the title
NicolasDorier
commented
Jun 18, 2019
|
WalletTestsAsync worked well after this. |
|
Tests are still randomly failing. I'll take a look at what's going on.
|
|
But the software works on the RegTest now. |
|
Also looks like running the failing tests again makes the tests pass. |
|
Next time tests ran right away. I think it was just a fluke. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two issues were found:
Somehow in tests the runtime params are not set and make tests fail.